Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix code scanning alerts #1155

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix: fix code scanning alerts #1155

merged 1 commit into from
Feb 15, 2024

Conversation

zchenwei
Copy link
Contributor

@zchenwei zchenwei commented Feb 15, 2024

Problem

Fix code scanning alerts and add deps-dev to allow dev dependencies update from dependabot

Solution

Additional Notes

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zchenwei zchenwei requested a review from a team as a code owner February 15, 2024 00:13
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b911b2) 93.86% compared to head (ad12fa8) 93.86%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1155   +/-   ##
=======================================
  Coverage   93.86%   93.86%           
=======================================
  Files         150      150           
  Lines        6114     6114           
  Branches     1838     1838           
=======================================
  Hits         5739     5739           
  Misses        357      357           
  Partials       18       18           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b911b2...ad12fa8. Read the comment docs.

@zchenwei zchenwei merged commit 575cbcc into main Feb 15, 2024
11 checks passed
@zchenwei zchenwei deleted the fix-codescanning branch February 15, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants